[Mlir-commits] [mlir] [mlir][emitc] Relax `hasSideEffect` rules for Var/Member (PR #145011)

[Gil Rapaport]

aniragil wrote:

> But in that case, it doesn't matter, since `load` is basically a reference to address being read, so you can not end with change of order if you do so, since even if the data changes, the load operation itself remains the same, since it refers the memory location on stack rather than the name semantically speaking. It could be problematic, if you end up with the extra `bind` somehow that got moved further, and the load is done through the bind, but if we assume that `writes` remain the same (which they will), I don't see how any of that would affect anything?

Not sure I follow: Semantically, the load op reads from memory regardless of memory location. Could you explain over the example above?

https://github.com/llvm/llvm-project/pull/145011