[Mlir-commits] [mlir] [mlir] Added `Convergent` trait that matches LLVM's semantics (PR #152358)

[Mehdi Amini]

joker-eph wrote:

> The exact issue is
> ...

You're showing me some pseudo source program, but I'm not sure what is the actual issue in MLIR and how this patch solves it right now.


> On one hand I agree with you that adding something that might change in future isn't good. 

This isn't exactly what I am saying I believe: I'm saying that it isn't good to add something that isn't well defined and documented, for which we can't tell users about how to use it.

>  On the other that's hard to reason about proper design without having convergent CF examples to support.

Aren't the example from the presentation and the Clang codegen a good reference about the examples to support?

Of course we could work around it by saying that "Convergent" is defined exactly as LLVM, and actually restrict it to LLVM function with flat CFGs only. But then that becomes a property of the LLVM layer and not something central in MLIR.



https://github.com/llvm/llvm-project/pull/152358