[Mlir-commits] [mlir] [mlir][vector] Support multi-dimensional vectors in VectorFromElementsLowering (PR #151175)

[Yang Bai]

yangtetris wrote:

> This should be implemented the same way #132227 is implemented. We should never do unrolling like this in conversion. It should always be a seperate pattern.

Thank you for your feedback. Decoupling the unrolling transformation and conversion seems like a good idea. However, I'm wondering if the conversion pattern only supports 1-D vectors, then how would we support converting multi-dim vectors in VectorToLLVMDialectInterface? There is no transformation stage in the `convert-to-llvm` pass. Or, is it okay to not support `from_elements` with multi-dim vectors in the `convert-to-llvm`?

https://github.com/llvm/llvm-project/pull/151175