[Mlir-commits] [mlir] [mlir] Added `Convergent` trait that matches LLVM's semantics (PR #152358)

[Nikolay Panchenko]

================
@@ -570,8 +572,9 @@ def NVVM_Barrier0Op : NVVM_Op<"barrier0"> {
   }];
 }
 
-def NVVM_BarrierOp : NVVM_Op<"barrier", [AttrSizedOperandSegments]> {
-  let arguments = (ins     
+def NVVM_BarrierOp : NVVM_Op<"barrier",
+  [Convergent, AttrSizedOperandSegments]> {
----------------
npanchen wrote:

That's is based on [LLVM's assumption](https://github.com/llvm/llvm-project/blob/main/llvm/include/llvm/IR/IntrinsicsNVVM.td#L1353-L1355) that intrinsics are convergent.
See [my other reply](https://github.com/llvm/llvm-project/pull/152358#discussion_r2258226097) about consistency of convergent properties.

https://github.com/llvm/llvm-project/pull/152358