[Mlir-commits] [mlir] [MLIR] Integrate LLVM Optimization Remarks Infrastructure (PR #152474)
Mehdi Amini
llvmlistbot at llvm.org
Thu Aug 7 06:28:04 PDT 2025
================
@@ -212,6 +213,9 @@ class MLIRContext {
/// Returns the diagnostic engine for this context.
DiagnosticEngine &getDiagEngine();
+ /// Returns the remark engine for this context.
+ std::unique_ptr<RemarkEngine> &getRemarkEngine();
----------------
joker-eph wrote:
Don't leak implementation details:
```suggestion
RemarkEngine &getRemarkEngine();
```
Or:
```suggestion
RemarkEngine *getRemarkEngine();
```
If it can be null.
https://github.com/llvm/llvm-project/pull/152474
More information about the Mlir-commits
mailing list