[Mlir-commits] [mlir] [MLIR] Integrate LLVM Optimization Remarks Infrastructure (PR #152474)

[Mehdi Amini]

================
@@ -245,6 +249,14 @@ class MLIRContext {
   /// (attributes, operations, types, etc.).
   llvm::hash_code getRegistryHash();
 
+  /// Set up optimization remarks for the context.
+  void setupOptimizationRemarks(
+      StringRef outputPath, StringRef outputFormat, bool printAsEmitRemarks,
+      const std::optional<std::string> &categoryPassName = std::nullopt,
+      const std::optional<std::string> &categoryMissName = std::nullopt,
----------------
joker-eph wrote:

```suggestion
      const std::optional<std::string> &categoryPassedName = std::nullopt,
      const std::optional<std::string> &categoryMissedName = std::nullopt,
```

I think we notify that an optimization "passed" or "missed".
I don't read it as a verb, and so "pass" make me always wonder what is has to do with our passes.

https://github.com/llvm/llvm-project/pull/152474