[Mlir-commits] [mlir] [mlir][cmake] Fix MLIR shared library installation (PR #152195)

[Boyana Norris]

================
@@ -388,6 +388,9 @@ function(add_mlir_library name)
 
   if(TARGET ${name})
     target_link_libraries(${name} INTERFACE ${LLVM_COMMON_LIBS})
+    if(ARG_INSTALL_WITH_TOOLCHAIN)
+      set_target_properties(${name} PROPERTIES MLIR_INSTALL_WITH_TOOLCHAIN TRUE)
----------------
brnorris03 wrote:

Actually I am unable to get `libMLIR.so*` to be installed without the property, even when I add and use the `add_mlir_library_install` argument. In trying to do this, it seems a lot more intrusive and messy than adding the property. I am curious, what is the disadvantage of using a property?

https://github.com/llvm/llvm-project/pull/152195