[Mlir-commits] [mlir] [mlir] Added `Convergent` trait that matches LLVM's semantics (PR #152358)

[Mehdi Amini]

================
@@ -1054,7 +1058,8 @@ def NVVM_CpAsyncWaitGroupOp : NVVM_Op<"cp.async.wait.group">,
   let assemblyFormat = "$n attr-dict";
 }
 
-def NVVM_CpAsyncMBarrierArriveOp : NVVM_Op<"cp.async.mbarrier.arrive"> {
+def NVVM_CpAsyncMBarrierArriveOp : NVVM_Op<"cp.async.mbarrier.arrive",
+  [Convergent]> {
----------------
joker-eph wrote:

> If so, I don't see it has been discussed in that comment/thread.

The comment is a general one, so it potentially applies to all the intrinsics :)

> As for cp.async.mbarrier.arrive, it's marked in LLVM with [IntrConvergent](https://github.com/llvm/llvm-project/blob/main/llvm/include/llvm/IR/IntrinsicsNVVM.td#L1401-L1402).

I do have low confidence for LLVM current annotation as a reliable source of documentation right now.

https://github.com/llvm/llvm-project/pull/152358