[Mlir-commits] [mlir] [mlir][vector] Support multi-dimensional vectors in VectorFromElementsLowering (PR #151175)

[Kunwar Grover]

https://github.com/Groverkss requested changes to this pull request.

I don't think this is how it should be done for N-D vectors. This should be done the same way as other vector ops do, by seperating the unrolling transformation from the conversion.

Most LLVM conversions only support 1-D/0-D vectors. And there are seperate transformations which unroll.

https://github.com/llvm/llvm-project/pull/151175