[Mlir-commits] [mlir] [MLIR][LLVM] Model llvm.module_asm instruction (PR #151996)

[Morris Hafner]

mmha wrote:

Ah I didn't see that patch!

The background for this PR was that it would enable codegen for FileScopeAsmDecl in ClangIR. It seems like I can use the new attribute without any issues. A downside of attributes is that they can't carry any location information but neither GCC nor LLVM IR do this for top level asm statements, so I'm not going to bother with a new op in CIR, either.

I'm closing this PR.

https://github.com/llvm/llvm-project/pull/151996