[Mlir-commits] [mlir] c1add93 - [mlir][spirv] Change Spirv.GlobalVariableOp builtin -> built_in (#152148)

[llvmlistbot at llvm.org]

Author: moscickimilosz
Date: 2025-08-05T15:47:37-04:00
New Revision: c1add93e45ecf4e5bbc50a933bbb451f0b9596eb

URL: https://github.com/llvm/llvm-project/commit/c1add93e45ecf4e5bbc50a933bbb451f0b9596eb
DIFF: https://github.com/llvm/llvm-project/commit/c1add93e45ecf4e5bbc50a933bbb451f0b9596eb.diff

LOG: [mlir][spirv] Change Spirv.GlobalVariableOp builtin -> built_in (#152148)

GlobalVariableOp describes that built_in specifies SPIR-V BuiltIn
decoration associated with the op. The attribute was defined as builtin
in the tablegen (no uderscore). This was causing correct
GlobalVariableOp decorations like: built_in("GlobalInvocationId") to be
saved as a new attribute making it impossible to access the built_in
attribute through getBuiltinAttr.

Added: 
    

Modified: 
    mlir/include/mlir/Dialect/SPIRV/IR/SPIRVStructureOps.td

Removed: 
    


################################################################################
diff  --git a/mlir/include/mlir/Dialect/SPIRV/IR/SPIRVStructureOps.td b/mlir/include/mlir/Dialect/SPIRV/IR/SPIRVStructureOps.td
index 7986025d6ca31..3bd3510fec8f3 100644
--- a/mlir/include/mlir/Dialect/SPIRV/IR/SPIRVStructureOps.td
+++ b/mlir/include/mlir/Dialect/SPIRV/IR/SPIRVStructureOps.td
@@ -451,7 +451,7 @@ def SPIRV_GlobalVariableOp : SPIRV_Op<"GlobalVariable", [InModuleScope, Symbol]>
     OptionalAttr<I32Attr>:$location,
     OptionalAttr<I32Attr>:$binding,
     OptionalAttr<I32Attr>:$descriptor_set,
-    OptionalAttr<StrAttr>:$builtin,
+    OptionalAttr<StrAttr>:$built_in,
     OptionalAttr<SPIRV_LinkageAttributesAttr>:$linkage_attributes
   );