[Mlir-commits] [mlir] [mlir][vector] Add alignment attribute to `maskedload` and `maskedstore` (PR #151690)

[Erick Ochoa Lopez]

amd-eochoalo wrote:

@kuhar, I added a simple AlignmentBytes struct here https://github.com/llvm/llvm-project/pull/151690/commits/8c65e3ddbe3bc96d4a021fc15743c756f3d98ffb I think this might be good enough for now, but happy to make changes.

@banach-space Thanks for the review! I addressed your comments in several commits. I don't want to spam you with multiple e-mails, but if you prefer, I can reply back to your comments with the commit id that is relevant. One question I had was about making the tests identical between `memref.{store,load}` and `vector.{store,load,maskedstore,maskedload}`. They looked already as close as possible, so I am not sure what concretely was asked. I swapped the `error at +1` to `error at below` and made the types more consistent. Please let me know more concretely what you had in mind and I would be happy to make the changes.

https://github.com/llvm/llvm-project/pull/151690