[Mlir-commits] [mlir] [mlir][OpenMP][NFC] Fix gcc 14 warning (PR #151941)

Tom Eccles llvmlistbot at llvm.org
Mon Aug 4 04:02:00 PDT 2025


https://github.com/tblah created https://github.com/llvm/llvm-project/pull/151941

GCC couldn't tell that the enum is checked exhaustively and so was warning about there being no return on this path from the function.

>From a554bec0bd25a15830d5bda102b818cdd2097b1a Mon Sep 17 00:00:00 2001
From: Tom Eccles <tom.eccles at arm.com>
Date: Mon, 4 Aug 2025 10:59:22 +0000
Subject: [PATCH] [mlir][OpenMP][NFC] Fix gcc 14 warning

GCC couldn't tell that the enum is checked exhaustively and so was
warning about there being no return on this path from the function.
---
 .../Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp   | 1 +
 1 file changed, 1 insertion(+)

diff --git a/mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp b/mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp
index 49e1e55c686a6..762cc88d9fc3d 100644
--- a/mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp
+++ b/mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp
@@ -3391,6 +3391,7 @@ static llvm::omp::Directive convertCancellationConstructType(
   case omp::ClauseCancellationConstructType::Taskgroup:
     return llvm::omp::Directive::OMPD_taskgroup;
   }
+  llvm_unreachable("Unhandled cancellation construct type");
 }
 
 static LogicalResult



More information about the Mlir-commits mailing list