[Mlir-commits] [mlir] [mlir] MemRefToSPIRV propagate alignment attributes from MemRef ops. (PR #151723)

[Jakub Kuderski]

kuhar wrote:

> * It is unclear to me at the moment whether non-PhysicalStorageBuffers may have an alignment attribute. At the moment I am assuming they won't.

PSB requires alignment, and in the other storage classes alignment is optional.

> * The alignment attribute added to the SPIR-V operations is 32-bits wide while the alignment attribute in MemRef operations is 64-bits wide. I would recommend changing this to 64-bits [per this comment. ](https://github.com/llvm/llvm-project/pull/144344#discussion_r2150375562). However, the current definition constraints alignment to be 32 bits wide.

This is because the SPIR-V spec specifies alignment as a 32-bit power-of-two number.


https://github.com/llvm/llvm-project/pull/151723