[Mlir-commits] [mlir] Reland "[mlir][spirv] Fix UpdateVCEPass to deduce the correct set of capabilities" (PR #151502)

Jakub Kuderski llvmlistbot at llvm.org
Fri Aug 1 07:42:34 PDT 2025


================
@@ -95,19 +95,16 @@ static LogicalResult checkAndUpdateCapabilityRequirements(
   return success();
 }
 
-static SetVector<spirv::Capability>
-addAllImpliedCapabilities(SetVector<spirv::Capability> &caps) {
-  SetVector<spirv::Capability> allCaps;
-  while (!caps.empty()) {
-    spirv::Capability cap = caps.pop_back_val();
-    allCaps.insert(cap);
-    ArrayRef<spirv::Capability> impliedCaps = getDirectImpliedCapabilities(cap);
-    for (spirv::Capability impliedCap : impliedCaps) {
-      if (!allCaps.contains(impliedCap))
-        caps.insert(impliedCap);
-    }
+static void addAllImpliedCapabilities(SetVector<spirv::Capability> &caps) {
+  size_t old_size{0};
----------------
kuhar wrote:

```suggestion
  size_t old_size = 0;
```

https://github.com/llvm/llvm-project/pull/151502


More information about the Mlir-commits mailing list