[Mlir-commits] [mlir] [mlir][linalg] Add getCollapsedVecType and update vectorization of linalg.unpack (PR #151503)

[Andrzej Warzyński]

banach-space wrote:

>  I'm not sure if we unit-test these kind of stuff

Not really, otherwise we would end up with _many_ unit tests 😅. From https://llvm.org/docs/TestingGuide.html#unit-tests
> In general unit tests are reserved for targeting the support library and other generic data structure, we prefer relying on regression tests for testing transformations and analysis on the IR.

Admittedly, this leaves room for interpretation From my experience, we don't really test such helper hooks in isolation. Instead, we rely on IR tests for the transformations in which such hooks are used. Hopefully this makes sense :)

https://github.com/llvm/llvm-project/pull/151503