[Mlir-commits] [mlir] [mlir][vector] Canonicalize/fold 'order preserving' transposes (PR #135841)

[Andrzej Warzyński]

banach-space wrote:

> Thanks @banach-space I'll address these comments, but just to mention that there still is test that fails (hangs) for me, it is test/Dialect/ArmSME/vector-legalization.mlir

In that case, I think the right approach is to first remove `ConvertIllegalShapeCastOpsToTransposes` (I suspect it's no longer needed), and then we can relax this logic.

Sorry for the back-and-forth, but let’s keep things as-is for now. Would you mind leaving a TODO for me to revisit and relax these constraints? Ideally, reference `ConvertIllegalShapeCastOpsToTransposes` in the comment.

Also, would you mind replacing `failure()` with `notifyMatchFailure()`? Thanks!

https://github.com/llvm/llvm-project/pull/135841