[Mlir-commits] [mlir] [mlir] Fix MemRefType alignment in ConvertVectorToLLVM (PR #137389)

[Micah Weston]

================
@@ -1937,18 +2002,24 @@ void mlir::populateVectorToLLVMConversionPatterns(
                VectorExtractElementOpConversion, VectorExtractOpConversion,
                VectorFMAOp1DConversion, VectorInsertElementOpConversion,
                VectorInsertOpConversion, VectorPrintOpConversion,
-               VectorTypeCastOpConversion, VectorScaleOpConversion,
-               VectorLoadStoreConversion<vector::LoadOp>,
-               VectorLoadStoreConversion<vector::MaskedLoadOp>,
-               VectorLoadStoreConversion<vector::StoreOp>,
-               VectorLoadStoreConversion<vector::MaskedStoreOp>,
-               VectorGatherOpConversion, VectorScatterOpConversion,
-               VectorExpandLoadOpConversion, VectorCompressStoreOpConversion,
-               VectorSplatOpLowering, VectorSplatNdOpLowering,
-               VectorScalableInsertOpLowering, VectorScalableExtractOpLowering,
-               MaskedReductionOpConversion, VectorInterleaveOpLowering,
-               VectorDeinterleaveOpLowering, VectorFromElementsLowering,
-               VectorScalableStepOpLowering>(converter);
+               VectorTypeCastOpConversion, VectorScaleOpConversion>(ctx),
+      patterns.add<VectorLoadStoreConversion<vector::LoadOp>>(
+          ctx, useVectorAlignment),
+      patterns.add<VectorLoadStoreConversion<vector::MaskedLoadOp>>(
+          ctx, useVectorAlignment),
+      patterns.add<VectorLoadStoreConversion<vector::StoreOp>>(
+          ctx, useVectorAlignment),
+      patterns.add<VectorLoadStoreConversion<vector::MaskedStoreOp>>(
+          ctx, useVectorAlignment),
+      patterns.add<VectorGatherOpConversion>(ctx, useVectorAlignment),
+      patterns.add<VectorScatterOpConversion>(ctx, useVectorAlignment),
----------------
red1bluelost wrote:

These expressions should be separated by semicolons, not commas.

Also, I think you could combine all the patterns that use `useVectorAlignment` into one call to `add` with multiple template arguments. `add` should just forward the extra option to each pattern constructor.

https://github.com/llvm/llvm-project/pull/137389