[Mlir-commits] [mlir] [mlir] Fix `--mlir-print-ir-tree-dir` when the symbol name contains `/` (PR #137686)
Mehdi Amini
llvmlistbot at llvm.org
Wed Apr 30 04:41:58 PDT 2025
joker-eph wrote:
The test fails on Windows as expected:
> # | Error while creating directory C:\ws\src\build\tools\mlir\test\Pass\Output\ir-printing-file-tree.mlir.tmp\builtin_module_outer\func_func_sym\backslash: no such file or directory
I pushed the fix now, should fix the CI.
> I was wondering if there was a standard LLVM "sanitization" function for path names. Especially on Windows there could be a lot of edge cases for strings that are allowed symbol names but are not valid Windows path names.
Good point: I searched in `llvm/include/llvm/Support/FileSystem.h` but couldn't find anything right now.
https://github.com/llvm/llvm-project/pull/137686
More information about the Mlir-commits
mailing list