https://github.com/krzysz00 commented: Overall feels better, I've got some comments Also, can you stick a test under mlir/test/Dialect/AMDGPU to make sure this parses/prints correctly? https://github.com/llvm/llvm-project/pull/137498