[Mlir-commits] [mlir] [MLIR][GPU] Add a pattern to rewrite gpu.subgroup_id (PR #137671)

[Alan Li]

================
@@ -88,6 +92,7 @@ inline void populateGpuRewritePatterns(RewritePatternSet &patterns) {
   populateGpuAllReducePatterns(patterns);
   populateGpuGlobalIdPatterns(patterns);
   populateGpuShufflePatterns(patterns);
+  populateGpuSubgroupIdPatterns(patterns);
----------------
lialan wrote:

I see. SPV links `get_sub_group_id` function to get the subgroup id. So I think we should just remove this line inside `populateGpuRewritePatterns`.

side note: SPIRV uses the same calculation method to compute subgroup_id.

https://github.com/llvm/llvm-project/pull/137671