[Mlir-commits] [mlir] 1c8e5e2 - [mlir][gpu] Fix breaking constructor from GPUSubgroupSizeToROCDL (#137439)

[llvmlistbot at llvm.org]

Author: Stanley Winata
Date: 2025-04-25T20:25:06-07:00
New Revision: 1c8e5e223fdbb7ce2752d9c30b72519b37376d8c

URL: https://github.com/llvm/llvm-project/commit/1c8e5e223fdbb7ce2752d9c30b72519b37376d8c
DIFF: https://github.com/llvm/llvm-project/commit/1c8e5e223fdbb7ce2752d9c30b72519b37376d8c.diff

LOG: [mlir][gpu] Fix breaking constructor from GPUSubgroupSizeToROCDL (#137439)

This PR addressed a bug from llvm/llvm-project#137360. which was using
GPUSubgroupSizeToROCDL to patterns function that do not have a valid
constructor for it. This is causing compilation error below:

error: constructor inherited by 'GPUSubgroupSizeOpToROCDL' from base
class 'ConvertOpToLLVMPattern<mlir::gpu::SubgroupSizeOp>' is implicitly
deleted

Signed-off-by: Stanley Winata <stanley.winata at amd.com>

Added: 
    

Modified: 
    mlir/lib/Conversion/GPUToROCDL/LowerGpuOpsToROCDLOps.cpp

Removed: 
    


################################################################################
diff  --git a/mlir/lib/Conversion/GPUToROCDL/LowerGpuOpsToROCDLOps.cpp b/mlir/lib/Conversion/GPUToROCDL/LowerGpuOpsToROCDLOps.cpp
index 0a6fb6451f700..dd16ec4b73e9f 100644
--- a/mlir/lib/Conversion/GPUToROCDL/LowerGpuOpsToROCDLOps.cpp
+++ b/mlir/lib/Conversion/GPUToROCDL/LowerGpuOpsToROCDLOps.cpp
@@ -455,9 +455,7 @@ void mlir::populateGpuToROCDLConversionPatterns(
   // TODO: Add alignment for workgroup memory
   patterns.add<GPUDynamicSharedMemoryOpLowering>(converter);
 
-  patterns
-      .add<GPUShuffleOpLowering, GPULaneIdOpToROCDL, GPUSubgroupSizeOpToROCDL>(
-          converter);
+  patterns.add<GPUShuffleOpLowering, GPULaneIdOpToROCDL>(converter);
   patterns.add<GPUSubgroupSizeOpToROCDL>(converter, chipset);
 
   populateMathToROCDLConversionPatterns(converter, patterns);