[Mlir-commits] [mlir] [mlir] Fix typo in CSE transform (PR #137341)

llvmlistbot at llvm.org llvmlistbot at llvm.org
Fri Apr 25 07:35:15 PDT 2025


https://github.com/bubblepipe created https://github.com/llvm/llvm-project/pull/137341

"Replace all uses, but do not _remote_ the operation yet" should be "Replace all uses, but do not _remove_ the operation yet".

>From e5340d90d657c9a19b2a00bb728355ed8d8fd09d Mon Sep 17 00:00:00 2001
From: bubblepipe <bubblepipe42 at gmail.com>
Date: Fri, 25 Apr 2025 22:29:57 +0800
Subject: [PATCH] remote->remove

---
 mlir/lib/Transforms/CSE.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/mlir/lib/Transforms/CSE.cpp b/mlir/lib/Transforms/CSE.cpp
index 3affd88d158de..8e03f62894bab 100644
--- a/mlir/lib/Transforms/CSE.cpp
+++ b/mlir/lib/Transforms/CSE.cpp
@@ -140,7 +140,7 @@ void CSEDriver::replaceUsesAndDelete(ScopedMapTy &knownValues, Operation *op,
     if (auto *rewriteListener =
             dyn_cast_if_present<RewriterBase::Listener>(rewriter.getListener()))
       rewriteListener->notifyOperationReplaced(op, existing);
-    // Replace all uses, but do not remote the operation yet. This does not
+    // Replace all uses, but do not remove the operation yet. This does not
     // notify the listener because the original op is not erased.
     rewriter.replaceAllUsesWith(op->getResults(), existing->getResults());
     opsToErase.push_back(op);
@@ -156,7 +156,7 @@ void CSEDriver::replaceUsesAndDelete(ScopedMapTy &knownValues, Operation *op,
         if (all_of(v.getUses(), wasVisited))
           rewriteListener->notifyOperationReplaced(op, existing);
 
-    // Replace all uses, but do not remote the operation yet. This does not
+    // Replace all uses, but do not remove the operation yet. This does not
     // notify the listener because the original op is not erased.
     rewriter.replaceUsesWithIf(op->getResults(), existing->getResults(),
                                wasVisited);



More information about the Mlir-commits mailing list