https://github.com/gysit approved this pull request. LGTM I would probably use OptionalParameter<"FlatSymbolRefAttr"> if possible. That way the custom parser and printer may not be necessary. https://github.com/llvm/llvm-project/pull/137269