[Mlir-commits] [mlir] [mlir][AMDGPU] Implement gpu.subgroup_reduce with DPP intrinsics on AMD GPUs (PR #133204)

Jakub Kuderski llvmlistbot at llvm.org
Wed Apr 23 08:01:35 PDT 2025


================
@@ -68,6 +69,20 @@ void populateGpuLowerClusteredSubgroupReduceToShufflePatterns(
     RewritePatternSet &patterns, unsigned subgroupSize,
     unsigned shuffleBitwidth = 32, PatternBenefit benefit = 1);
 
+/// Collect a set of patterns to lower `gpu.subgroup_reduce` into `amdgpu.dpp`
+/// ops over scalar types. Assumes that the subgroup has
+/// `subgroupSize` lanes. Applicable only to AMD GPUs.
----------------
kuhar wrote:

nit: Reflow this comment? I think `subgroupSize` should fit on the previous line

https://github.com/llvm/llvm-project/pull/133204


More information about the Mlir-commits mailing list