[Mlir-commits] [mlir] [MLIR][LLVM] Allow strings in module flag value (PR #136793)

[Tobias Gysi]

================
@@ -1776,9 +1776,10 @@ llvm.mlir.alias external @y5 : i32 {
 // -----
 
 module {
-  // expected-error at +2 {{expected integer value}}
-  // expected-error at +1 {{failed to parse ModuleFlagAttr parameter 'value' which is to be a `uint32_t`}}
-  llvm.module_flags [#llvm.mlir.module_flag<error, "wchar_size", "yolo">]
+  llvm.func @foo()
+
+  // expected-error at +1 {{only integer and string values are currently supported}}
----------------
gysit wrote:

```suggestion
  // expected-error at below {{only integer and string values are currently supported}}
```
ultra nit: below is preferred (I know it is not consistent).

https://github.com/llvm/llvm-project/pull/136793