[Mlir-commits] [mlir] [MLIR][Affine] Fix affine.apply verifier and add functionality to demote invalid symbols to dims (PR #128289)

[LLVM Continuous Integration]

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `premerge-monolithic-linux` running on `premerge-linux-1` while building `mlir` at step 6 "build-unified-tree".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/153/builds/29595

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 6 (build-unified-tree) failure: build (failure)
...
4.696 [4012/12/113] Linking CXX executable bin/clang-installapi
4.696 [4012/11/114] Linking CXX executable bin/clang-include-cleaner
4.703 [4012/10/115] Linking CXX executable bin/clang-query
4.727 [4012/9/116] Linking CXX executable bin/clang-change-namespace
4.741 [4012/8/117] Linking CXX executable bin/find-all-symbols
5.162 [4012/7/118] Linking CXX executable bin/clangd-indexer
5.165 [4012/6/119] Linking CXX executable bin/clangd
5.215 [4012/5/120] Linking CXX executable bin/clangd-fuzzer
5.338 [4012/4/121] Linking CXX executable bin/clang-tidy
8.666 [4012/3/122] Building CXX object tools/mlir/lib/Dialect/Affine/IR/CMakeFiles/obj.MLIRAffineDialect.dir/AffineOps.cpp.o
FAILED: tools/mlir/lib/Dialect/Affine/IR/CMakeFiles/obj.MLIRAffineDialect.dir/AffineOps.cpp.o 
CCACHE_CPP2=yes CCACHE_HASHDIR=yes /usr/bin/ccache /usr/bin/clang++ -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/build/buildbot/premerge-monolithic-linux/build/tools/mlir/lib/Dialect/Affine/IR -I/build/buildbot/premerge-monolithic-linux/llvm-project/mlir/lib/Dialect/Affine/IR -I/build/buildbot/premerge-monolithic-linux/build/tools/mlir/include -I/build/buildbot/premerge-monolithic-linux/llvm-project/mlir/include -I/build/buildbot/premerge-monolithic-linux/build/include -I/build/buildbot/premerge-monolithic-linux/llvm-project/llvm/include -gmlt -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -Wundef -Werror=mismatched-tags -Werror=global-constructors -O3 -DNDEBUG  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -std=c++17 -MD -MT tools/mlir/lib/Dialect/Affine/IR/CMakeFiles/obj.MLIRAffineDialect.dir/AffineOps.cpp.o -MF tools/mlir/lib/Dialect/Affine/IR/CMakeFiles/obj.MLIRAffineDialect.dir/AffineOps.cpp.o.d -o tools/mlir/lib/Dialect/Affine/IR/CMakeFiles/obj.MLIRAffineDialect.dir/AffineOps.cpp.o -c /build/buildbot/premerge-monolithic-linux/llvm-project/mlir/lib/Dialect/Affine/IR/AffineOps.cpp
/build/buildbot/premerge-monolithic-linux/llvm-project/mlir/lib/Dialect/Affine/IR/AffineOps.cpp:1392:18: error: member reference type 'mlir::AffineMap' is not a pointer
  assert(mapOrSet->getNumInputs() == numOperands &&
         ~~~~~~~~^
/usr/include/assert.h:93:27: note: expanded from macro 'assert'
     (static_cast <bool> (expr)                                         \
                          ^~~~
/build/buildbot/premerge-monolithic-linux/llvm-project/mlir/lib/Dialect/Affine/IR/AffineOps.cpp:1443:3: note: in instantiation of function template specialization 'legalizeDemotedDims<mlir::AffineMap>' requested here
  legalizeDemotedDims<MapOrSet>(*mapOrSet, *operands);
  ^
/build/buildbot/premerge-monolithic-linux/llvm-project/mlir/lib/Dialect/Affine/IR/AffineOps.cpp:1510:3: note: in instantiation of function template specialization 'canonicalizeMapOrSetAndOperands<mlir::AffineMap>' requested here
  canonicalizeMapOrSetAndOperands<AffineMap>(map, operands);
  ^
/build/buildbot/premerge-monolithic-linux/llvm-project/mlir/lib/Dialect/Affine/IR/AffineOps.cpp:1392:18: note: did you mean to use '.' instead?
  assert(mapOrSet->getNumInputs() == numOperands &&
                 ^~
                 .
/usr/include/assert.h:93:27: note: expanded from macro 'assert'
     (static_cast <bool> (expr)                                         \
                          ^
/build/buildbot/premerge-monolithic-linux/llvm-project/mlir/lib/Dialect/Affine/IR/AffineOps.cpp:1425:18: error: member reference type 'mlir::AffineMap' is not a pointer
  assert(mapOrSet->getNumInputs() == operands.size() &&
         ~~~~~~~~^
/usr/include/assert.h:93:27: note: expanded from macro 'assert'
     (static_cast <bool> (expr)                                         \
                          ^~~~
/build/buildbot/premerge-monolithic-linux/llvm-project/mlir/lib/Dialect/Affine/IR/AffineOps.cpp:1425:18: note: did you mean to use '.' instead?
  assert(mapOrSet->getNumInputs() == operands.size() &&
                 ^~
                 .
/usr/include/assert.h:93:27: note: expanded from macro 'assert'
     (static_cast <bool> (expr)                                         \
                          ^
/build/buildbot/premerge-monolithic-linux/llvm-project/mlir/lib/Dialect/Affine/IR/AffineOps.cpp:1392:18: error: member reference type 'mlir::IntegerSet' is not a pointer
  assert(mapOrSet->getNumInputs() == numOperands &&
         ~~~~~~~~^
/usr/include/assert.h:93:27: note: expanded from macro 'assert'
     (static_cast <bool> (expr)                                         \

```

</details>

https://github.com/llvm/llvm-project/pull/128289