[Mlir-commits] [mlir] [MLIR][Affine] Fix affine.apply verifier and add functionality to demote invalid symbols to dims (PR #128289)

[LLVM Continuous Integration]

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `ppc64le-mlir-rhel-clang` running on `ppc64le-mlir-rhel-test` while building `mlir` at step 5 "build-check-mlir-build-only".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/129/builds/19360

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 5 (build-check-mlir-build-only) failure: build (failure)
...
50.158 [204/8/4023] Linking CXX static library lib/libLLVMGlobalISel.a
50.162 [204/7/4024] Linking CXX static library lib/libMLIRExecutionEngineUtils.a
50.188 [203/7/4025] Linking CXX static library lib/libLLVMOrcJIT.a
50.208 [203/6/4026] Linking CXX static library lib/libMLIRTargetLLVM.a
50.255 [201/7/4027] Linking CXX static library lib/libMLIRROCDLTarget.a
50.256 [201/6/4028] Linking CXX static library lib/libMLIRNVVMTarget.a
50.548 [201/5/4029] Linking CXX executable tools/mlir/unittests/Dialect/LLVMIR/MLIRLLVMIRTests
50.612 [201/4/4030] Linking CXX executable tools/mlir/unittests/Dialect/OpenACC/MLIROpenACCTests
50.639 [201/3/4031] Linking CXX executable tools/mlir/unittests/Dialect/Transform/MLIRTransformDialectTests
71.938 [201/2/4032] Building CXX object tools/mlir/lib/Dialect/Affine/IR/CMakeFiles/obj.MLIRAffineDialect.dir/AffineOps.cpp.o
FAILED: tools/mlir/lib/Dialect/Affine/IR/CMakeFiles/obj.MLIRAffineDialect.dir/AffineOps.cpp.o 
ccache /home/buildbots/llvm-external-buildbots/clang.19.1.7/bin/clang++ -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/buildbots/llvm-external-buildbots/workers/ppc64le-mlir-rhel-test/ppc64le-mlir-rhel-clang-build/build/tools/mlir/lib/Dialect/Affine/IR -I/home/buildbots/llvm-external-buildbots/workers/ppc64le-mlir-rhel-test/ppc64le-mlir-rhel-clang-build/llvm-project/mlir/lib/Dialect/Affine/IR -I/home/buildbots/llvm-external-buildbots/workers/ppc64le-mlir-rhel-test/ppc64le-mlir-rhel-clang-build/build/tools/mlir/include -I/home/buildbots/llvm-external-buildbots/workers/ppc64le-mlir-rhel-test/ppc64le-mlir-rhel-clang-build/llvm-project/mlir/include -I/home/buildbots/llvm-external-buildbots/workers/ppc64le-mlir-rhel-test/ppc64le-mlir-rhel-clang-build/build/include -I/home/buildbots/llvm-external-buildbots/workers/ppc64le-mlir-rhel-test/ppc64le-mlir-rhel-clang-build/llvm-project/llvm/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -Wundef -Werror=mismatched-tags -Werror=global-constructors -O3 -DNDEBUG -std=c++17  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -MD -MT tools/mlir/lib/Dialect/Affine/IR/CMakeFiles/obj.MLIRAffineDialect.dir/AffineOps.cpp.o -MF tools/mlir/lib/Dialect/Affine/IR/CMakeFiles/obj.MLIRAffineDialect.dir/AffineOps.cpp.o.d -o tools/mlir/lib/Dialect/Affine/IR/CMakeFiles/obj.MLIRAffineDialect.dir/AffineOps.cpp.o -c /home/buildbots/llvm-external-buildbots/workers/ppc64le-mlir-rhel-test/ppc64le-mlir-rhel-clang-build/llvm-project/mlir/lib/Dialect/Affine/IR/AffineOps.cpp
/home/buildbots/llvm-external-buildbots/workers/ppc64le-mlir-rhel-test/ppc64le-mlir-rhel-clang-build/llvm-project/mlir/lib/Dialect/Affine/IR/AffineOps.cpp:1392:18: error: member reference type 'mlir::AffineMap' is not a pointer
 1392 |   assert(mapOrSet->getNumInputs() == numOperands &&
      |          ~~~~~~~~^
/usr/include/assert.h:90:27: note: expanded from macro 'assert'
   90 |      (static_cast <bool> (expr)                                         \
      |                           ^~~~
/home/buildbots/llvm-external-buildbots/workers/ppc64le-mlir-rhel-test/ppc64le-mlir-rhel-clang-build/llvm-project/mlir/lib/Dialect/Affine/IR/AffineOps.cpp:1443:3: note: in instantiation of function template specialization 'legalizeDemotedDims<mlir::AffineMap>' requested here
 1443 |   legalizeDemotedDims<MapOrSet>(*mapOrSet, *operands);
      |   ^
/home/buildbots/llvm-external-buildbots/workers/ppc64le-mlir-rhel-test/ppc64le-mlir-rhel-clang-build/llvm-project/mlir/lib/Dialect/Affine/IR/AffineOps.cpp:1510:3: note: in instantiation of function template specialization 'canonicalizeMapOrSetAndOperands<mlir::AffineMap>' requested here
 1510 |   canonicalizeMapOrSetAndOperands<AffineMap>(map, operands);
      |   ^
/home/buildbots/llvm-external-buildbots/workers/ppc64le-mlir-rhel-test/ppc64le-mlir-rhel-clang-build/llvm-project/mlir/lib/Dialect/Affine/IR/AffineOps.cpp:1392:18: note: did you mean to use '.' instead?
 1392 |   assert(mapOrSet->getNumInputs() == numOperands &&
      |                  ^~
      |                  .
/usr/include/assert.h:90:27: note: expanded from macro 'assert'
   90 |      (static_cast <bool> (expr)                                         \
      |                           ^
/home/buildbots/llvm-external-buildbots/workers/ppc64le-mlir-rhel-test/ppc64le-mlir-rhel-clang-build/llvm-project/mlir/lib/Dialect/Affine/IR/AffineOps.cpp:1425:18: error: member reference type 'mlir::AffineMap' is not a pointer
 1425 |   assert(mapOrSet->getNumInputs() == operands.size() &&
      |          ~~~~~~~~^
/usr/include/assert.h:90:27: note: expanded from macro 'assert'
   90 |      (static_cast <bool> (expr)                                         \
      |                           ^~~~
/home/buildbots/llvm-external-buildbots/workers/ppc64le-mlir-rhel-test/ppc64le-mlir-rhel-clang-build/llvm-project/mlir/lib/Dialect/Affine/IR/AffineOps.cpp:1425:18: note: did you mean to use '.' instead?
 1425 |   assert(mapOrSet->getNumInputs() == operands.size() &&
      |                  ^~
      |                  .
/usr/include/assert.h:90:27: note: expanded from macro 'assert'
   90 |      (static_cast <bool> (expr)                                         \
      |                           ^
/home/buildbots/llvm-external-buildbots/workers/ppc64le-mlir-rhel-test/ppc64le-mlir-rhel-clang-build/llvm-project/mlir/lib/Dialect/Affine/IR/AffineOps.cpp:1392:18: error: member reference type 'mlir::IntegerSet' is not a pointer
 1392 |   assert(mapOrSet->getNumInputs() == numOperands &&
      |          ~~~~~~~~^
/usr/include/assert.h:90:27: note: expanded from macro 'assert'
   90 |      (static_cast <bool> (expr)                                         \

```

</details>

https://github.com/llvm/llvm-project/pull/128289