[Mlir-commits] [mlir] [MLIR][Affine] Fix affine.apply verifier and add functionality to demote invalid symbols to dims (PR #128289)

Tue Apr 22 16:44:11 PDT 2025

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `flang-runtime-cuda-gcc` running on `as-builder-7` while building `mlir` at step 6 "build-flang-rt".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/152/builds/2208

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 6 (build-flang-rt) failure: cmake (failure)
...
27.008 [527/19/6124] Linking CXX static library lib/libLLVMVECodeGen.a
27.009 [527/18/6125] Linking CXX static library lib/libLLVMXCoreCodeGen.a
27.010 [527/17/6126] Linking CXX static library lib/libLLVMLoongArchCodeGen.a
27.024 [527/16/6127] Linking CXX static library lib/libLLVMBPFCodeGen.a
27.035 [527/15/6128] Linking CXX static library lib/libLLVMNVPTXCodeGen.a
27.063 [526/15/6129] Linking CXX static library lib/libLLVMWebAssemblyCodeGen.a
27.068 [526/14/6130] Linking CXX static library lib/libMLIRNVVMTarget.a
27.071 [526/13/6131] Linking CXX static library lib/libLLVMSPIRVCodeGen.a
27.078 [526/12/6132] Linking CXX static library lib/libLLVMMipsCodeGen.a
27.082 [526/11/6133] Building CXX object tools/mlir/lib/Dialect/Affine/IR/CMakeFiles/obj.MLIRAffineDialect.dir/AffineOps.cpp.o
FAILED: tools/mlir/lib/Dialect/Affine/IR/CMakeFiles/obj.MLIRAffineDialect.dir/AffineOps.cpp.o 
ccache /usr/bin/g++ -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/buildbot/worker/as-builder-7/ramdisk/flang-runtime-cuda-gcc/build/tools/mlir/lib/Dialect/Affine/IR -I/home/buildbot/worker/as-builder-7/ramdisk/flang-runtime-cuda-gcc/llvm-project/mlir/lib/Dialect/Affine/IR -I/home/buildbot/worker/as-builder-7/ramdisk/flang-runtime-cuda-gcc/build/tools/mlir/include -I/home/buildbot/worker/as-builder-7/ramdisk/flang-runtime-cuda-gcc/llvm-project/mlir/include -I/home/buildbot/worker/as-builder-7/ramdisk/flang-runtime-cuda-gcc/build/include -I/home/buildbot/worker/as-builder-7/ramdisk/flang-runtime-cuda-gcc/llvm-project/llvm/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -Wundef -Wno-unused-but-set-parameter -Wno-deprecated-copy -O3 -DNDEBUG  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -std=c++17 -MD -MT tools/mlir/lib/Dialect/Affine/IR/CMakeFiles/obj.MLIRAffineDialect.dir/AffineOps.cpp.o -MF tools/mlir/lib/Dialect/Affine/IR/CMakeFiles/obj.MLIRAffineDialect.dir/AffineOps.cpp.o.d -o tools/mlir/lib/Dialect/Affine/IR/CMakeFiles/obj.MLIRAffineDialect.dir/AffineOps.cpp.o -c /home/buildbot/worker/as-builder-7/ramdisk/flang-runtime-cuda-gcc/llvm-project/mlir/lib/Dialect/Affine/IR/AffineOps.cpp
In file included from /usr/include/c++/11/cassert:44,
                 from /home/buildbot/worker/as-builder-7/ramdisk/flang-runtime-cuda-gcc/llvm-project/mlir/include/mlir/Analysis/Presburger/Matrix.h:21,
                 from /home/buildbot/worker/as-builder-7/ramdisk/flang-runtime-cuda-gcc/llvm-project/mlir/include/mlir/Analysis/Presburger/IntegerRelation.h:19,
                 from /home/buildbot/worker/as-builder-7/ramdisk/flang-runtime-cuda-gcc/llvm-project/mlir/include/mlir/Analysis/FlatLinearValueConstraints.h:12,
                 from /home/buildbot/worker/as-builder-7/ramdisk/flang-runtime-cuda-gcc/llvm-project/mlir/include/mlir/Interfaces/ValueBoundsOpInterface.h:12,
                 from /home/buildbot/worker/as-builder-7/ramdisk/flang-runtime-cuda-gcc/llvm-project/mlir/lib/Dialect/Affine/IR/AffineOps.cpp:21:
/home/buildbot/worker/as-builder-7/ramdisk/flang-runtime-cuda-gcc/llvm-project/mlir/lib/Dialect/Affine/IR/AffineOps.cpp: In instantiation of ‘void legalizeDemotedDims(MapOrSet&, llvm::SmallVectorImpl<mlir::Value>&) [with MapOrSet = mlir::AffineMap]’:
/home/buildbot/worker/as-builder-7/ramdisk/flang-runtime-cuda-gcc/llvm-project/mlir/lib/Dialect/Affine/IR/AffineOps.cpp:1443:32:   required from ‘void canonicalizeMapOrSetAndOperands(MapOrSet*, llvm::SmallVectorImpl<mlir::Value>*) [with MapOrSet = mlir::AffineMap]’
/home/buildbot/worker/as-builder-7/ramdisk/flang-runtime-cuda-gcc/llvm-project/mlir/lib/Dialect/Affine/IR/AffineOps.cpp:1510:45:   required from here
/home/buildbot/worker/as-builder-7/ramdisk/flang-runtime-cuda-gcc/llvm-project/mlir/lib/Dialect/Affine/IR/AffineOps.cpp:1392:10: error: base operand of ‘->’ has non-pointer type ‘mlir::AffineMap’
 1392 |   assert(mapOrSet->getNumInputs() == numOperands &&
      |          ^~~~~~~~
/home/buildbot/worker/as-builder-7/ramdisk/flang-runtime-cuda-gcc/llvm-project/mlir/lib/Dialect/Affine/IR/AffineOps.cpp:1425:10: error: base operand of ‘->’ has non-pointer type ‘mlir::AffineMap’
 1425 |   assert(mapOrSet->getNumInputs() == operands.size() &&
      |          ^~~~~~~~
/home/buildbot/worker/as-builder-7/ramdisk/flang-runtime-cuda-gcc/llvm-project/mlir/lib/Dialect/Affine/IR/AffineOps.cpp: In instantiation of ‘void legalizeDemotedDims(MapOrSet&, llvm::SmallVectorImpl<mlir::Value>&) [with MapOrSet = mlir::IntegerSet]’:
/home/buildbot/worker/as-builder-7/ramdisk/flang-runtime-cuda-gcc/llvm-project/mlir/lib/Dialect/Affine/IR/AffineOps.cpp:1443:32:   required from ‘void canonicalizeMapOrSetAndOperands(MapOrSet*, llvm::SmallVectorImpl<mlir::Value>*) [with MapOrSet = mlir::IntegerSet]’
/home/buildbot/worker/as-builder-7/ramdisk/flang-runtime-cuda-gcc/llvm-project/mlir/lib/Dialect/Affine/IR/AffineOps.cpp:1515:46:   required from here
/home/buildbot/worker/as-builder-7/ramdisk/flang-runtime-cuda-gcc/llvm-project/mlir/lib/Dialect/Affine/IR/AffineOps.cpp:1392:10: error: base operand of ‘->’ has non-pointer type ‘mlir::IntegerSet’
 1392 |   assert(mapOrSet->getNumInputs() == numOperands &&
      |          ^~~~~~~~
/home/buildbot/worker/as-builder-7/ramdisk/flang-runtime-cuda-gcc/llvm-project/mlir/lib/Dialect/Affine/IR/AffineOps.cpp:1425:10: error: base operand of ‘->’ has non-pointer type ‘mlir::IntegerSet’
 1425 |   assert(mapOrSet->getNumInputs() == operands.size() &&
      |          ^~~~~~~~
27.089 [526/10/6134] Linking CXX static library lib/libLLVMPowerPCCodeGen.a
27.118 [526/9/6135] Linking CXX static library lib/libLLVMARMCodeGen.a
27.131 [526/8/6136] Linking CXX static library lib/libLLVMRISCVCodeGen.a
27.139 [526/7/6137] Linking CXX static library lib/libLLVMHexagonCodeGen.a
27.180 [526/6/6138] Linking CXX static library lib/libLLVMAArch64CodeGen.a
27.197 [526/5/6139] Linking CXX static library lib/libLLVMX86CodeGen.a
28.025 [526/4/6140] Building AMDGPUGenRegisterInfo.inc...
28.262 [526/3/6141] Building CXX object lib/LTO/CMakeFiles/LLVMLTO.dir/LTO.cpp.o
28.325 [526/2/6142] Building AMDGPUGenRegisterBank.inc...
28.843 [526/1/6143] Linking CXX static library lib/libFortranEvaluate.a
ninja: build stopped: subcommand failed.

```

</details>

https://github.com/llvm/llvm-project/pull/128289