[Mlir-commits] [mlir] [vector][linearize] Refactor code to push target bit width out of patterns (PR #136581)
James Newling
llvmlistbot at llvm.org
Tue Apr 22 07:40:44 PDT 2025
newling wrote:
> Overall makes sense. In fact, this is a nice clean-up, thanks!
>
> > As a follow-up to this PR, I propose that user(s) of the targetVectorBitWidth move legalBecauseOfBitwidth to their code bases, and then remove it from upstream.
>
> How are we going to "drive" the existing tests that depend on this? (through e.g. `test-vector-linearize=target-vector-bitwidth=128`).
Great point. I will try refactor the testing to make it an easier lift, and wait for the folks who use this to give their thoughts
https://github.com/llvm/llvm-project/pull/136581
More information about the Mlir-commits
mailing list