[Mlir-commits] [mlir] Relax checks on vector.shape_cast (PR #136587)

Andrzej Warzyński llvmlistbot at llvm.org
Tue Apr 22 06:38:01 PDT 2025


banach-space wrote:

This approach makes more sense to me — thanks!

I don't see a need to "special-case" vector.shape_cast; this PR aligns more closely with how I’ve been thinking about it. In fact, I wasn’t even aware of the restrictions this is removing - and I suspect Diego wasn’t either, based on [his comment](https://github.com/llvm/llvm-project/pull/135855#issuecomment-2809234621).

Given the feedback so far, I’d suggest closing #135855 and marking this PR as ready for review instead - unless I’m missing something? 🤔

https://github.com/llvm/llvm-project/pull/136587


More information about the Mlir-commits mailing list