[Mlir-commits] [mlir] [mlir][vector] Sink vector.extract/splat into load/store ops (PR #134389)

[Andrzej Warzyński]

https://github.com/banach-space approved this pull request.

This looks good to me, thanks for addressing all my comments! I've left a few minor suggestions that I’d appreciate you addressing before landing, but nothing major.

AFAIK, Diego is currently traveling, but from what I can tell, he’s fine with not treating these patterns as canonicalizations for now:

> I'm still kind of borderline, but let’s move forward with this as an independent pattern.

With that in mind, would you mind adding a TODO to revisit the idea of making these canonicalizations in the future? Just to reflect that some of us (myself included) would be in favor — we’re just not blocking this for now.

Once these are addressed, this should be good to land (provided there are no new comments).

https://github.com/llvm/llvm-project/pull/134389