[Mlir-commits] [mlir] [MLIR][TableGen] Warn on APInt parameter without custom comparator (PR #135970)

[Tobias Gysi]

gysit wrote:

> It could technically break downstream builds that can not experience the issue. For example, even the old version of the Builtin_IntegerAttribute could not trigger the assert, as the type parameter of the attribute contains the bit width information and short-circuited the equality operator.

True, it sounds like a very doable integration task for downstream projects though? I would thus tend to make it an error since warnings can go unnoticed quite easily. No strong opinion from my side.


https://github.com/llvm/llvm-project/pull/135970