[Mlir-commits] [mlir] [mlir][vector] Update the folder for vector.{insert|extract} (PR #136579)

[Andrzej Warzyński]

banach-space wrote:

> Thanks for fixing my tests, I'll make sure to follow the testing guide next time!

No worries at all - the testing guide is still quite new and unfamiliar to most contributors. Rome wasn’t built in a day :)

>  my understanding is that this -1 should be considered as an OOB access, as only -1 constants (as in -1 attributes) are representing poison accesses (if I understand correctly).

Why do you think we should treat `-1` (as an attribute) and `%c_neg_1` (an SSA value that's a compile-time constant equal to -1) differently? Is there documentation I'm missing, or another rationale?

To me, they both represent the same value at compile time, so I would expect them to be treated consistently, regardless of the underlying representation.

https://github.com/llvm/llvm-project/pull/136579