[Mlir-commits] [mlir] [mlir][memref] Fix rollback in test case during `convert-to-llvm` (PR #135958)

[Matthias Springer]

matthias-springer wrote:

Before this change, the test was broken when running with `--convert-to-llvm="filter-dialects=memref"`. The `memref.generic_atomic_rmw` was not lowered. (We lowered it, then rolled it back.) We did not notice that because only one test is currently checked:

```
// Same below, but using the `ConvertToLLVMPatternInterface` entry point
// and the generic `convert-to-llvm` pass. This produces slightly different IR
// because the conversion target is set up differently. Only one test case is
// checked.
// RUN: mlir-opt --convert-to-llvm="filter-dialects=memref" --split-input-file %s | FileCheck --check-prefix=CHECK-INTERFACE %s
```

I have to sprinkle a few more `CHECK-INTERFACE`. Maybe not as comprehensive as the `CHECK:`, but at least making sure that the correct LLVM dialect op was generated. I will leave this PR as "draft" until then.



https://github.com/llvm/llvm-project/pull/135958