[Mlir-commits] [mlir] [SCF] add debug label for MergeNestedParallelLoops pattern (PR #135980)

[Mehdi Amini]

joker-eph wrote:

> That's a fair point. Like I said earlier, an RFC to require a name is probably the larger fix. I mean, can we change "debugName" to "patternName" and then my commit is acceptable?

Probably: but this isn't free, it makes all patterns more costly, and the framework heavier in production.

> It seems to me like this is a neat feature for customizing what you want or not want to be canonicalized depending on various needs of your downstream implementation.

I would argue that the canonical form of the IR isn't something meant to be customized with this kind of fine grain control.
Also, relying on some sort of string backdoor does not seem like a great API on the principle as well.

https://github.com/llvm/llvm-project/pull/135980