[Mlir-commits] [mlir] [MLIR][LLVM] Fix #llvm.constant_range crashing in storage uniquer (PR #135772)
Tobias Gysi
llvmlistbot at llvm.org
Tue Apr 15 23:10:45 PDT 2025
================
@@ -383,6 +383,12 @@ class StringRefParameter<string desc = "", string value = ""> :
let defaultValue = value;
}
+// For APInts, which require comparison over different bitwidths
----------------
gysit wrote:
```suggestion
// For APInts, which require comparison supporting different bitwidths. The default
// APInt comparison operator asserts when the bitwidths differ, so a custom
// implementation is necessary.
```
nit: Let's maybe expand a bit why this is necessary.
https://github.com/llvm/llvm-project/pull/135772
More information about the Mlir-commits
mailing list