Jerry-Ge wrote: Thanks for the rebase! Overall looks good after the 1st pass. Could you also mention the code refactoring for Conv2d checks in the commit message and PR title? https://github.com/llvm/llvm-project/pull/135738