[Mlir-commits] [mlir] [MLIR][LLVM] Fix #llvm.constant_range crashing in storage uniquer (PR #135772)

[Tobias Gysi]

gysit wrote:

hmm could it be that this is related to the `operator==` implementation:
https://github.com/llvm/llvm-project/blob/9a6c001b125d7d37b8f2c8b96461768c797c4e3f/llvm/include/llvm/ADT/APInt.h#L1056

For some reason APInt seems to expect that the `operator==` is only called on APInts of the same bit width.

I am not entirely sure but I believe that the storage uniquer use the equality operator to avoid has value collisions. So maybe this is the root of the problem?

With regards to the approach, I would first like to fully understand the problem before moving forward. In theory APIInt should work with the storage uniquer. If it doesn't, there may be more problematic attributes.

https://github.com/llvm/llvm-project/pull/135772