[Mlir-commits] [mlir] [mlir][vector] transpose(broadcast) -> broadcast canonicalization (PR #135096)

James Newling llvmlistbot at llvm.org
Fri Apr 11 12:56:58 PDT 2025


newling wrote:

I just realized there is a folder https://github.com/llvm/llvm-project/commit/a480d75fe48d6c4e0ab4ae5fbbf719c57f5ced35 which is a subset of this PR (only considers case where source is scalar). I'll remove that folder

> Also, I noticed that you force-pushed — just a heads-up that we generally try to avoid that during the review process in LLVM:

Ok, noted for next time. Thanks for pointing me to these guidelines (of which there don't seem to be too many, I should just read them..)

> Since this adds a canonicalization, let’s give it a day or two before merging, just to allow time for other reviewers to take a look.

That's fine, no rush. 

https://github.com/llvm/llvm-project/pull/135096


More information about the Mlir-commits mailing list