[Mlir-commits] [mlir] [mlir][vector] transpose(broadcast) -> broadcast canonicalization (PR #135096)

Andrzej Warzyński llvmlistbot at llvm.org
Fri Apr 11 12:30:35 PDT 2025


https://github.com/banach-space approved this pull request.

LGTM — thank you for working on this, and for being so diligent with the documentation and testing 🙏🏻

Since this adds a canonicalization, let’s give it a day or two before merging, just to allow time for other reviewers to take a look.

Also, I noticed that you force-pushed — just a heads-up that we generally try to avoid that during the review process in LLVM:

* https://llvm.org/docs/GitHub.html#rebasing-pull-requests-and-force-pushes

(one of many bits of documentation that’s not easy to find!)

https://github.com/llvm/llvm-project/pull/135096


More information about the Mlir-commits mailing list