[Mlir-commits] [mlir] [mlir][linalg][vector] Refine create{Read|Write}OrMasked{Read|Write} (nfc) (PR #135350)

Andrzej WarzyƄski llvmlistbot at llvm.org
Fri Apr 11 08:29:07 PDT 2025


================
@@ -1582,8 +1620,11 @@ static Operation *createWriteOrMaskedWrite(OpBuilder &builder, Location loc,
 ///     : vector<32x4x1x16x2xf32>, tensor<32x4x1x16x2xf32>
 ///
 /// If the (3) input vector sizes are not provided, the vector sizes are
-/// determined by the result tensor shape. Also, we update the inBounds
-/// attribute instead of masking.
+/// determined by the result tensor shape and the `in_bounds`
+/// attribute is used instead of masking to mark
+///
+/// NOTE: The input vector sizes specify the dimensions corresponding to the
+/// outer dimensions of the output tensor. The remaining dimensions are
----------------
banach-space wrote:

Indeed, sorry! Fixed in this [commit](https://github.com/llvm/llvm-project/pull/135350/commits/5aa309c12a927da7bf8816a7b7efd2bb6b6cd123).

https://github.com/llvm/llvm-project/pull/135350


More information about the Mlir-commits mailing list