[Mlir-commits] [mlir] [mlir][x86vector] AVX Convert/Broadcast BF16 to F32 instructions (PR #135143)

[Andrzej Warzyński]

================
@@ -0,0 +1,48 @@
+// REQUIRES: target=x86{{.*}}
+
+// RUN: mlir-opt %s \
+// RUN:   -convert-vector-to-llvm="enable-x86vector" -convert-to-llvm \
+// RUN:   -reconcile-unrealized-casts | \
+// RUN: mlir-translate --mlir-to-llvmir | \
+// RUN: llc -mcpu=sierraforest | \
----------------
banach-space wrote:

What's the value of checking assembly? Shouldn't this be tested in LLVM instead?

I appreciate the desire for more complete, e2e testing, but these things come at a cost and I'd rather for us to focus on the bare minimum. Especially for things that are definitely tested in LLVM (i.e. lowering LLVM intrinsics to ASM).

Hopefully this make sense :) 

https://github.com/llvm/llvm-project/pull/135143