[Mlir-commits] [mlir] [mlir][vector] transpose(broadcast) -> broadcast canonicalization (PR #135096)

[Andrzej Warzyński]

https://github.com/banach-space commented:

Thanks for the updates!

I really like the idea behind `vector-transpose-canonicalize.mlir` — we should start doing something similar for other patterns as well! To help streamline this going forward, would you mind creating a subdirectory called `canonicalize/` and moving the test file there? I'd also suggest dropping "canonicalize" from the file name itself, and keeping all your tests in that subdirectory (*).

Sorry for the extra churn — I hadn’t realized this was a viable option earlier.

(*) I know I previously suggested the opposite. At the time, I wrongly assumed we could only have one file dedicated to canonicalization tests. That was my mistake!

https://github.com/llvm/llvm-project/pull/135096