[Mlir-commits] [mlir] Save unregistered attrs after type conversion. (PR #135084)

Bart Chrzaszcz llvmlistbot at llvm.org
Thu Apr 10 06:51:08 PDT 2025


bartchr808 wrote:

> I believe you need to handle this on the caller side: save the arguments and restore them later.

Oh how can I save the arguments? Like where should I put the attributes? Like create a C++ Operation->Attribute map and re add them after the pass

> Out of curiosity, what kind of information are you attaching to call ops?

We have `sdy::TensorShardingAttr`s that we attach to mainly function inputs/outputs and StableHLO custom calls with the name `sdy.sharding`. Unfortunately here I discovered we also need to attach them to `CallOp`s, and that wasn't being preserved :/ 

https://github.com/llvm/llvm-project/pull/135084


More information about the Mlir-commits mailing list