[Mlir-commits] [mlir] [mlir][vector] transpose(broadcast) -> broadcast canonicalization (PR #135096)

[Andrzej Warzyński]

https://github.com/banach-space commented:

Nice—this is very neatly crafted, thanks!

I left a few minor comments inline, and one broader question about whether this qualifies as a canonicalization - curious to hear your thoughts on that.

One additional note: it would be good to include negative tests. Also, I’d suggest putting more extensive testing under `mlir/test/Vector`, and keeping only minimal illustrative examples in `canonicalization.mlir` to avoid bloating that file.

https://github.com/llvm/llvm-project/pull/135096