[Mlir-commits] [mlir] [mlir][linalg] Produce canonical linalg.generic for im2col (PR #134675)

[Quinn Dawkins]

qedawkins wrote:

There's no need for conditional interface attachment; `getIterationDomainTileFromOperandTile`, `getIterationDomainTileFromResultTile`, and any of the other methods that actually perform tiling are allowed to fail. Thus the choice to manually compute the input access offsets within the body of the generic is a conscious decision to enable at least some of the tiling interface methods to work on the `im2col` op. `affine_map<(d0, d1, d2) -> (d0, d1 floordiv 14 + d2 floordiv 12, d1 mod 14 + (d2 mod 12) floordiv 4, d2 mod 4)>` is not invertible (as noted) and thus will cause any attempt to tile the op to fail.

https://github.com/llvm/llvm-project/pull/134675