[Mlir-commits] [mlir] [MLIR][Tensor] Remove FoldDimOf[Expand|Collapse]Shape Pattern (PR #134219)

[Mehdi Amini]

joker-eph wrote:

>>> These pattern are also wrong
>> Wrong how?
> Wrong cause they are crashing. 

OK, we had a vocabulary mismatch here, "wrong" confused me, thanks for clarifying what you meant.

> So I think we dont even need to get into canonicalization vs. not discussion.

You want to remove something done in canonicalization to make it not part of canonicalization: so while I sympathize, I don't quite see how you can avoid the conversation.

https://github.com/llvm/llvm-project/pull/134219