[Mlir-commits] [mlir] [MLIR][Tensor] Remove FoldDimOf[Expand|Collapse]Shape Pattern (PR #134219)

[Mehdi Amini]

joker-eph wrote:

> . These pattern are also wrong

Wrong how?

> and redundant

It's a bit ambiguous what you call redundant, if you compare to "other things that are not part of canonicalization" then it's a bit dubious to claim it "redundant" as it won't be part of the canonicalization run.

> So the resolution here is to remove this pattern. The question of whether all the tensor.dim resolution needs to happen during canonicalization or not is a separate issue that we can revisit. It would be better to not block this change cause this is removing a redundant and wrong pattern.

This is all an opinion, but I'd rather see you elaborate you're thinking to enlighten everyone, instead of just making a strong claim that you're not trying to substantiate right now (other than very unspecific terms like "wrong" and "redundant").

https://github.com/llvm/llvm-project/pull/134219