[Mlir-commits] [mlir] [mlir][vector] Sink vector.extract/splat into load/store ops (PR #134389)

[Andrzej Warzyński]

https://github.com/banach-space commented:

Nice, thank you for contributing this!

I was a bit surprised that `vector.load` and `vector.store` only accept MemRef(s). @dcaballe , since you added `vector.store`, do you know the context? That would help us position `ApplySinkVectorMemPatternsOp` accordingly (e.g., do we need a dedicated TD Op?).

More comments inline.

https://github.com/llvm/llvm-project/pull/134389